Xiaodong DENG created AIRFLOW-2798:
--------------------------------------
Summary: Remove needless arguments
Key: AIRFLOW-2798
URL: https://issues.apache.org/jira/browse/AIRFLOW-2798
Project: Apache Airflow
Issue Type: Improvement
Components: models
Reporter: Xiaodong DENG
Assignee: Xiaodong DENG
If `email_on_failure` or `email_on_failure` set to TRUE and email available,
there will be email sent out on event of retry or failure.
In the implementation, there is a argument `is_retry` passed to method
`self.email_alert`. However, inside this method, this argument is not used at
all. I believer the initial author of this method was planning to differentiate
the email to be sent out, but for whatever reason this was not implemented.
Given in the email to be sent out, there will be a line "Try \{try_number} out
of \{max_tries}<br>", it would be fine not to differentiate *retry email* and
*failure email*.
Make sure you have checked _all_ steps below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
