Kengo Seki created AIRFLOW-2829:
-----------------------------------
Summary: Brush up the CI script for minikube
Key: AIRFLOW-2829
URL: https://issues.apache.org/jira/browse/AIRFLOW-2829
Project: Apache Airflow
Issue Type: Bug
Components: ci
Reporter: Kengo Seki
Assignee: Kengo Seki
Ran {{scripts/ci/kubernetes/minikube/start_minikube.sh}} locally and found some
points that can be improved:
- minikube version is hard-coded
- Defined but unused variables: {{$_HELM_VERSION}}, {{$_VM_DRIVER}}
- Undefined variables: {{$unameOut}}
- The following lines cause warnings if download is skipped:
{code}
69 sudo mv bin/minikube /usr/local/bin/minikube
70 sudo mv bin/kubectl /usr/local/bin/kubectl
{code}
- {{return}} s at line 81 and 96 won't work since it's outside of a function
- To run this script as a non-root user, {{-E}} is required for {{sudo}}. See
https://github.com/kubernetes/minikube/issues/1883.
{code}
105 _MINIKUBE="sudo PATH=$PATH minikube"
106
107 $_MINIKUBE config set bootstrapper localkube
108 $_MINIKUBE start --kubernetes-version=${_KUBERNETES_VERSION}
--vm-driver=none
109 $_MINIKUBE update-context
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
