[
https://issues.apache.org/jira/browse/AIRFLOW-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564359#comment-16564359
]
ASF GitHub Bot commented on AIRFLOW-1104:
-----------------------------------------
codecov-io edited a comment on issue #3568: AIRFLOW-1104 Update jobs.py so
Airflow does not over schedule tasks
URL:
https://github.com/apache/incubator-airflow/pull/3568#issuecomment-401878707
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=h1)
Report
> Merging
[#3568](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-airflow/commit/3b35d360f6ff8694b6fb4387901c182ca39160b5?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3568 +/- ##
==========================================
+ Coverage 77.51% 77.51% +<.01%
==========================================
Files 205 205
Lines 15751 15751
==========================================
+ Hits 12209 12210 +1
+ Misses 3542 3541 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[airflow/jobs.py](https://codecov.io/gh/apache/incubator-airflow/pull/3568/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzLnB5)
| `82.74% <100%> (ø)` | :arrow_up: |
|
[airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3568/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=)
| `88.58% <0%> (+0.04%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=footer).
Last update
[3b35d36...b04c9b1](https://codecov.io/gh/apache/incubator-airflow/pull/3568?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Concurrency check in scheduler should count queued tasks as well as running
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-1104
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1104
> Project: Apache Airflow
> Issue Type: Bug
> Environment: see https://github.com/apache/incubator-airflow/pull/2221
> "Tasks with the QUEUED state should also be counted below, but for now we
> cannot count them. This is because there is no guarantee that queued tasks in
> failed dagruns will or will not eventually run and queued tasks that will
> never run will consume slots and can stall a DAG. Once we can guarantee that
> all queued tasks in failed dagruns will never run (e.g. make sure that all
> running/newly queued TIs have running dagruns), then we can include QUEUED
> tasks here, with the constraint that they are in running dagruns."
> Reporter: Alex Guziel
> Priority: Minor
> Fix For: 2.0.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
