[
https://issues.apache.org/jira/browse/AIRFLOW-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565170#comment-16565170
]
ASF GitHub Bot commented on AIRFLOW-2836:
-----------------------------------------
codecov-io commented on issue #3674: [AIRFLOW-2836] Minor improvement of
contrib.sensors.FileSensor
URL:
https://github.com/apache/incubator-airflow/pull/3674#issuecomment-409544984
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=h1)
Report
> Merging
[#3674](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-airflow/commit/c37fc0b6ba19e3fe5656ae37cef9b59cef3c29e8?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3674 +/- ##
=========================================
- Coverage 77.5% 77.5% -0.01%
=========================================
Files 205 205
Lines 15753 15753
=========================================
- Hits 12210 12209 -1
- Misses 3543 3544 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3674/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=)
| `88.54% <0%> (-0.05%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=footer).
Last update
[c37fc0b...4d8abd8](https://codecov.io/gh/apache/incubator-airflow/pull/3674?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Minor improvement of contrib.sensors.FileSensor
> -----------------------------------------------
>
> Key: AIRFLOW-2836
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2836
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
>
> h4. *Background*
> The default *fs_conn_id* in contrib.sensors.FileSensor is '_*fs_default2*_'.
> However, when we initiate the database
> (https://github.com/apache/incubator-airflow/blob/master/airflow/utils/db.py#L88),
> there isn't such an entry. It doesn't exist anywhere else.
> h4. *Issue*
> The purpose of _contrib.sensors.FileSensor_ is mainly for checking local file
> system (of course can also be used for NAS). Then the path ("/") from default
> connection 'fs_default' would suffice.
> However, given the default value for *fs_conn_id* in
> contrib.sensors.FileSensor is "fs_default2" (a value doesn't exist), it will
> make the situation much more complex.
> When users intend to check local file system only, they should be able to
> leave *fs_conn_id* default directly, instead of going setting up another
> connection separately.
> h4. Proposal
> Change default value for *fs_conn_id* in contrib.sensors.FileSensor from
> "fs_default2" to "fs_default" (actually in the related test, the *fs_conn_id*
> are all specified to be "fs_default").
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
