[
https://issues.apache.org/jira/browse/AIRFLOW-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569930#comment-16569930
]
ASF subversion and git services commented on AIRFLOW-2845:
----------------------------------------------------------
Commit 5b7a28c7e0dade62bb4d087f25687821e7f11083 in incubator-airflow's branch
refs/heads/master from Yuliya Volkova
[ https://gitbox.apache.org/repos/asf?p=incubator-airflow.git;h=5b7a28c ]
[AIRFLOW-2845] Asserts in contrib package code are changed on raise ValueError
and TypeError (#3690)
> Remove asserts from the contrib code (change to legal exceptions)
> ------------------------------------------------------------------
>
> Key: AIRFLOW-2845
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2845
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
> Affects Versions: 1.9.0
> Reporter: Iuliia Volkova
> Assignee: Iuliia Volkova
> Priority: Minor
> Labels: easyfix
> Fix For: 2.0.0
>
>
> Hi guys. `asserts` is used in Airflow contrib package code . And from point
> of view for which purposes asserts are really is, it's not correct.
> If we look at documentation we could find information what asserts is debug
> tool:
> [https://docs.python.org/3/reference/simple_stmts.html#the-assert-statement]
> and also it is could be disabled globally by default.
> If you do not mind, I will be happy to prepare PR for remove asserts from the
> contrib module with changing it to raising errors with correct Exceptions and
> messages and not just "Assertion Error".
> I talk only about src (not about asserts in tests).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
