[
https://issues.apache.org/jira/browse/AIRFLOW-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570355#comment-16570355
]
ASF GitHub Bot commented on AIRFLOW-2860:
-----------------------------------------
awelsh93 opened a new pull request #3710: [AIRFLOW-2860] Update tests for druid
hook
URL: https://github.com/apache/incubator-airflow/pull/3710
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This pull request updates the tests for `airflow/hooks/druid_hook.py` and
also adds an assert so that `timeout` must be greater than or equal to 1
second. This should fix the failing build in #3707.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I ran `nosetests /tests/hooks/test_druid_hook.py`
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DruidHook: time variable is not updated correctly when checking for timeout
> ----------------------------------------------------------------------------
>
> Key: AIRFLOW-2860
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2860
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Reporter: Adam Welsh
> Assignee: Adam Welsh
> Priority: Trivial
> Fix For: 2.0.0
>
>
> The variable that is used in the condition to check if the Druid ingestion
> task has exceeded the max_ingestion_time is not updated correctly. It gets
> incremented by one (which is the default value for timeout) but should be
> incremented by timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
