[
https://issues.apache.org/jira/browse/AIRFLOW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572989#comment-16572989
]
ASF GitHub Bot commented on AIRFLOW-2874:
-----------------------------------------
verdan opened a new pull request #3719: [AIRFLOW-2874] Enables FAB's theme
support
URL: https://github.com/apache/incubator-airflow/pull/3719
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
2874](https://issues.apache.org/jira/browse/AIRFLOW-2874) issues and references
them in the PR title.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
In an effort to make Apache Airflow a white label application, we should
enable the FAB's theme support. Users can then easily change the theme
according to their needs. There already exists a configuration to set the
Navbar Color, that can be used in conjunction with the theme option, or can
simply be unset to fully utilize the theme. List of available themes are
available here:
https://github.com/dpgaspar/Flask-AppBuilder-Skeleton/blob/master/config.py#L88
_Note: Some of the dark themes might not work properly because of the charts
that we are using at the moment._
Here are some of the screenshots from different themes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable Flask App Builder theme support
> --------------------------------------
>
> Key: AIRFLOW-2874
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2874
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Verdan Mahmood
> Assignee: Verdan Mahmood
> Priority: Major
>
> To customize the look and feel of Apache Airflow (an effort towards making
> Airflow a whitelabel application), we should enable the support of FAB's
> theme, which can be set in configuration.
> Theme can be use in conjunction of existing `navbar_color` configuration or
> can be used separately by simple unsetting the navbar_color config.
>
> http://flask-appbuilder.readthedocs.io/en/latest/customizing.html#changing-themes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
