[
https://issues.apache.org/jira/browse/AIRFLOW-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573840#comment-16573840
]
ASF GitHub Bot commented on AIRFLOW-2759:
-----------------------------------------
amohan34 opened a new pull request #3722: [AIRFLOW-2759] Add changes to extract
proxy details at the base hook …
URL: https://github.com/apache/incubator-airflow/pull/3722
…level
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-2759\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2759
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-2759\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
To test, run the following commands within tests/contrib/hooks
nosetests test_gcp_api_base_hook_proxy.py --with-coverage
--cover-package=airflow.contrib.hooks.gcp_api_base_hook
### Commits
- [x†] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify proxy server based access to external platforms like Google cloud
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-2759
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2759
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Reporter: Aishwarya Mohan
> Assignee: Aishwarya Mohan
> Priority: Major
> Labels: hooks, proxy
>
> Several companies adopt a Proxy Server based approach in order to provide an
> additional layer of security while communicating with external platforms to
> establish legitimacy of caller and calle. A potential use case would be
> writing logs from Airflow to a cloud storage platform like google cloud via
> an intermediary proxy server.
> In the current scenario the proxy details need to be hardcoded and passed to
> the HTTP client library(httplib2) in the GoogleCloudBaseHook class
> (gcp_api_base_hook.py). It would be convenient if the proxy details (for
> example, host and port) can be extracted from the airflow configuration file
> as opposed to hardcoding the details at hook level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
