[
https://issues.apache.org/jira/browse/AIRFLOW-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577586#comment-16577586
]
ASF GitHub Bot commented on AIRFLOW-1368:
-----------------------------------------
Wouter-M opened a new pull request #3741: [AIRFLOW-1368] Add auto_remove for
DockerOperator
URL: https://github.com/apache/incubator-airflow/pull/3741
Dear Airflow maintainers,
Please take this PR into consideration. It adds the ability for containers
created by the `DockerOperator` to be removed automatically after execution.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-1368
Other issues which seem to be duplicate:
- https://issues.apache.org/jira/browse/AIRFLOW-516
- https://issues.apache.org/jira/browse/AIRFLOW-465
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR adds back the `auto_remove` option to the `DockerOperator`, which
will automatically delete the Docker container once it exits. This was added
before in PR #2411, but something went wrong there and it somehow got lost.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I have changed one of the unit tests to work with the change, ran the test
cases for the docker_operator, and testing airflow locally to check the docker
container gets removed if `auto_remove=True` and not removed if
`auto_remove=False`.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
I updated the doc comment.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Automatically remove the container when it exits
> ------------------------------------------------
>
> Key: AIRFLOW-1368
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1368
> Project: Apache Airflow
> Issue Type: Improvement
> Components: docker, operators
> Environment: MacOS Sierra Version 10.12.5
> Docker Community Edition Version 17.06.0-ce-mac18 Stable Channel
> Docker Base Image: puckel/docker-airflow
> Reporter: Nathaniel Varona
> Assignee: Nathaniel Varona
> Priority: Major
> Labels: docker
> Fix For: 1.9.0, 1.8.3
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> A container should automatically remove when it exits for short-term
> foreground processes.
> Manual Example:
> {{$ docker run -i --rm busybox echo 'Hello World!'}}
> {{> Hello World!}}
> {{$ docker ps -a}}
> Command output should have a list of clean running processes without having
> an {{Exited (0)}} status.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
