Fokko commented on a change in pull request #3742: [AIRFLOW-2892] Add CC,BCC
for SLA/Retry/Failure Emailing
URL: https://github.com/apache/incubator-airflow/pull/3742#discussion_r209462503
##########
File path: airflow/jobs.py
##########
@@ -708,22 +708,28 @@ def manage_slas(self, dag, session=None):
Blocking tasks:
<pre><code>{blocking_task_list}\n{bug}<code></pre>
""".format(bug=asciiart.bug, **locals())
- emails = []
+ emails = {'email': [], 'email_cc': [], 'email_bcc': []}
for t in dag.tasks:
Review comment:
Can we refactor this a bit? Separating the logic that you've added to
maintain backward compatible to a new function and add a test for this? This
will also make it more transparant. What do you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
