Fokko commented on a change in pull request #3475: [AIRFLOW-2315] Improve S3Hook URL: https://github.com/apache/incubator-airflow/pull/3475#discussion_r209463662
########## File path: airflow/hooks/S3_hook.py ########## @@ -275,7 +275,8 @@ def load_file(self, key, bucket_name=None, replace=False, - encrypt=False): + encrypt=False, + upload_args={}): Review comment: This can be quite dangerous indeed if you're not familiar with its behaviour: ``` MacBook-Pro-van-Fokko:~ fokkodriesprong$ python3 Python 3.7.0 (default, Jun 29 2018, 20:13:13) [Clang 9.1.0 (clang-902.0.39.2)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> def some_function(a={}): ... return a ... >>> some_function() {} >>> some_function()['lid'] = True >>> some_function() {'lid': True} ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services