[
https://issues.apache.org/jira/browse/AIRFLOW-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590723#comment-16590723
]
ASF GitHub Bot commented on AIRFLOW-2949:
-----------------------------------------
tzulberti-jampp opened a new pull request #3795: [AIRFLOW-2949] Add syntax
highlight for single quote strings
URL: https://github.com/apache/incubator-airflow/pull/3795
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
Added .s1 style class for single quoted strings on main.css to have color
highlight for single quote strings.
### Tests
There are no tests for the CSS selectos on main.css
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Syntax Highlight for Single Quote
> ---------------------------------
>
> Key: AIRFLOW-2949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2949
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Tomas Zulberti
> Priority: Major
> Attachments: image-2018-08-23-16-16-59-375.png
>
>
> When checking the code of any DAG, there is a highlight for double quote
> strings but there isn't any for single quote strings. pygments generate a
> special css class but there is no color asigned for them
>
> !image-2018-08-23-16-16-59-375.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
