[
https://issues.apache.org/jira/browse/AIRFLOW-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591839#comment-16591839
]
ASF GitHub Bot commented on AIRFLOW-2779:
-----------------------------------------
ashb opened a new pull request #3803: [AIRFLOW-2779] Restore Copyright notice
of GHE auth backend
URL: https://github.com/apache/incubator-airflow/pull/3803
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2779
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
At request of original author. Placed in NOTICES file to comply with
https://www.apache.org/legal/src-headers.html#headers.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Verify and correct licenses
> ---------------------------
>
> Key: AIRFLOW-2779
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2779
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Bolke de Bruin
> Priority: Major
> Labels: licenses
> Fix For: 1.10.0
>
>
> # {color:#000000}/airflow/security/utils.py{color}
> {color:#000000}2. ./airflow/security/kerberos.py{color}
> {color:#000000}3. ./airflow/www_rbac/static/jqClock.min.js{color}
> {color:#000000}4. ./airflow/www/static/bootstrap3-typeahead.min.js{color}
> {color:#000000}5.
> ./apache-airflow-1.10.0rc2+incubating/scripts/ci/flake8_diff.sh{color}
> {color:#000000}6. {color}[https://www.apache.org/legal/resolved.html#optional]
> {color:#000000}7. ./docs/license.rst{color}
> {color:#000000}8. airflow/contrib/auth/backends/google_auth.py{color}
> {color:#000000}9.
> /airflow/contrib/auth/backends/github_enterprise_auth.py{color}
> {color:#000000}10. /airflow/contrib/hooks/ssh_hook.py{color}
> {color:#000000}11. /airflow/minihivecluster.py{color}
> {color:#000000}This files [1][2] seem to be 3rd party ALv2 licensed files
> that refers to a NOTICE file, that information in that NOTICE file (at the
> very least the copyright into) should be in your NOTICE file. This should
> also be noted in LICENSE.{color}
>
> {color:#000000}LICENSE is:
> - missing jQuery clock [3] and typeahead [4], as they are ALv2 it’s not
> required to list them but it’s a good idea to do so.
> - missing the license for this [5]
> - this file [7] oddly has © 2016 GitHub, [Inc.at|http://inc.at/] the bottom
> of it{color}
>
> * {color:#000000}Year in NOTICE is not correct "2016 and onwards” isn’t
> valid as copyright has an expiry date{color}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
