ashb commented on issue #3796: [AIRFLOW-2824] - Add config to disable default 
conn creation
URL: 
https://github.com/apache/incubator-airflow/pull/3796#issuecomment-416951818
 
 
   Since I didn't say so I think the goal of this ticket is 💯.
   
   Ah the RBAC code there is an interesting one. Apart from that, everything in 
`initdb` is optional - airflow will operate fine with only ever running 
`upgradedb`. We have been running in prod since 1.8.2 only having done 
`upgradedb` and nothing has broken or missing (other than no sample charts or 
connections)
   
   I have no idea where KnowEvent(Type) is actually used - there are very few 
references to it in the rest of the code base that I could see other the 
creation there, and a view. Nothing ever seems to use it for anything else.... 
Maybe a candidate for dropping, though worth checking with @mistercrunch or 
someone else (still?) at AirBnB.
   
   Pre-loading of the DAG table didn't used to be required as starting the 
scheduler would do this job too, but on quick testing I'm not sure that's the 
case anymore.
   
   Hmm, the RBAC change should possibly be converted to be an actual Alembic 
migration, or at the very least done via upgradedb not just initdb!
   
   I have somewhat hijacked this issue though. Oops.
   
   Having written al that I'm not sure the way forward either.
   
   RBAC and KET should probably be in upgradedb. It might be worth merging them 
in to a single command behind a flag `airflow initdb --with-examples` which is 
more obvious/delibarate than having to know that `upgradedb` exists when all 
the tutorials just talk about initdb. THoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to