[
https://issues.apache.org/jira/browse/AIRFLOW-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598001#comment-16598001
]
ASF GitHub Bot commented on AIRFLOW-2988:
-----------------------------------------
jcao219 opened a new pull request #3826: [AIRFLOW-2988] Run specifically
python2 for dataflow
URL: https://github.com/apache/incubator-airflow/pull/3826
Apache beam does not yet support python3, so it's best to run dataflow
jobs with python2 specifically until python3 support is complete
(BEAM-1251), in case if the user's 'python' in PATH is python3.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GCP Dataflow hook should specifically run python2
> -------------------------------------------------
>
> Key: AIRFLOW-2988
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2988
> Project: Apache Airflow
> Issue Type: Improvement
> Components: Dataflow, gcp, hooks
> Reporter: Jimmy Cao
> Priority: Major
>
> Currently the GCP dataflow hook invokes 'python'
> [here|https://github.com/apache/incubator-airflow/blob/c3939c8e721870d263997e7aeaebc28e678d544b/airflow/contrib/hooks/gcp_dataflow_hook.py#L239].
> This can fail if the user's 'python' in PATH starts python 3, which Apache
> Beam does not yet support, (see BEAM-1251).
> It should be changed to 'python2' to ensure that Apache Beam is run with the
> correct version of Python.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
