[
https://issues.apache.org/jira/browse/AIRFLOW-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599204#comment-16599204
]
ASF GitHub Bot commented on AIRFLOW-2994:
-----------------------------------------
jgao54 closed pull request #3829: [AIRFLOW-2994] Fix flatten_results for
BigQueryOperator
URL: https://github.com/apache/incubator-airflow/pull/3829
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/contrib/hooks/bigquery_hook.py
b/airflow/contrib/hooks/bigquery_hook.py
index e4c0653bfe..aee84e9eef 100644
--- a/airflow/contrib/hooks/bigquery_hook.py
+++ b/airflow/contrib/hooks/bigquery_hook.py
@@ -476,7 +476,7 @@ def run_query(self,
destination_dataset_table=False,
write_disposition='WRITE_EMPTY',
allow_large_results=False,
- flatten_results=False,
+ flatten_results=None,
udf_config=False,
use_legacy_sql=None,
maximum_billing_tier=None,
diff --git a/airflow/contrib/operators/bigquery_operator.py
b/airflow/contrib/operators/bigquery_operator.py
index bda0b08c23..a8fdc66ec9 100644
--- a/airflow/contrib/operators/bigquery_operator.py
+++ b/airflow/contrib/operators/bigquery_operator.py
@@ -106,7 +106,7 @@ def __init__(self,
destination_dataset_table=False,
write_disposition='WRITE_EMPTY',
allow_large_results=False,
- flatten_results=False,
+ flatten_results=None,
bigquery_conn_id='bigquery_default',
delegate_to=None,
udf_config=False,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> flatten_results in BigQueryOperator/BigQueryHook should default to None
> -----------------------------------------------------------------------
>
> Key: AIRFLOW-2994
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2994
> Project: Apache Airflow
> Issue Type: Bug
> Components: gcp
> Affects Versions: 1.10.0
> Reporter: Chris Riccomini
> Priority: Major
> Fix For: 1.10.1
>
>
> Upon upgrading to 1.10, we began seeing issues with our queries that were
> using allow_large_results. They began failing because flatten_results now
> defaults to False. This should default to unset (None), as it did before.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
