[
https://issues.apache.org/jira/browse/AIRFLOW-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602049#comment-16602049
]
ASF GitHub Bot commented on AIRFLOW-2979:
-----------------------------------------
ashb closed pull request #3832: [AIRFLOW-2979] Make celery_result_backend conf
Backwards compatible
URL: https://github.com/apache/incubator-airflow/pull/3832
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/configuration.py b/airflow/configuration.py
index 9e80648c74..33376285be 100644
--- a/airflow/configuration.py
+++ b/airflow/configuration.py
@@ -139,6 +139,7 @@ class AirflowConfigParser(ConfigParser):
'celery': {
# Remove these keys in Airflow 1.11
'worker_concurrency': 'celeryd_concurrency',
+ 'result_backend': 'celery_result_backend',
'broker_url': 'celery_broker_url',
'ssl_active': 'celery_ssl_active',
'ssl_cert': 'celery_ssl_cert',
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deprecated Celery Option not in Options list
> ---------------------------------------------
>
> Key: AIRFLOW-2979
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2979
> Project: Apache Airflow
> Issue Type: Bug
> Components: celery
> Affects Versions: 1.10.0
> Reporter: Micheal Ascah
> Assignee: Kaxil Naik
> Priority: Critical
>
> References AIRFLOW-1840
> In airflow/configuration.py
> {code:java}
> # A two-level mapping of (section -> new_name -> old_name). When reading
> # new_name, the old_name will be checked to see if it exists. If it does a
> # DeprecationWarning will be issued and the old name will be used instead
> deprecated_options = {
> 'celery': {
> # Remove these keys in Airflow 1.11
> 'worker_concurrency': 'celeryd_concurrency',
> 'broker_url': 'celery_broker_url',
> 'ssl_active': 'celery_ssl_active',
> 'ssl_cert': 'celery_ssl_cert',
> 'ssl_key': 'celery_ssl_key',
> }
> }
> {code}
> This block is missing the renaming of celery_result_backend to just
> result_backed.
>
> When setting this through an environment variable, the deprecated config name
> is not being used and instead the default value in the file is being used.
> This is obviously remedied by the reading the UPDATING and setting the new
> name, but this change has broken back compat as far as I can tell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
