ashb commented on a change in pull request #3841: [AIRFLOW-XXX] Fix python3
errors in dev/airflow-jira
URL: https://github.com/apache/incubator-airflow/pull/3841#discussion_r215214012
##########
File path: dev/airflow-jira
##########
@@ -134,7 +134,7 @@ def compare(target_version):
for issue in issues:
is_merged = issue.key in merges
- print("{:<18}|{:<12}||{:<10}||{:<10}|{:<50}|{:<6}|{:<6}|{:<40}"
+ print("{:<18}|{!s:<12}||{!s:<10}||{!s:<10}|{:<50}|{:<6}|{:<6}|{:<40}"
Review comment:
Some of the objects passed in the format are not strings, but objects which
have a string representation. Without this change we get this error:
```
TypeError: non-empty format string passed to object.__format__
```
I'll improve this line a bit (using named args, rather than positional)
which will help a little bit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
