XD-DENG commented on issue #3903: [AIRFLOW-3067] categorize www_rbac Flask flash msg properly URL: https://github.com/apache/incubator-airflow/pull/3903#issuecomment-421664102 Hi @feng-tao, actually I though of these two concerns you’re pointing out: 1. to my understanding, bootstrap-theme.css is maintained using npm. We should not make change to it in our codebase. I hesitated if I should fix from bootstrap-theme.css, but eventually gave up due to this reason. 2. Putting “warning” rather than “danger”: I also hesitated back and forth on this. Some Exceptions here are not causing system-wide trouble, like failed to import Variable. Putting “danger” category seems too much (available options are only “success”, “info”, “warning”, “danger”).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
