[
https://issues.apache.org/jira/browse/AIRFLOW-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620671#comment-16620671
]
ASF GitHub Bot commented on AIRFLOW-3088:
-----------------------------------------
sethwoodworth opened a new pull request #3918: [AIRFLOW-3088] Include
slack-compatible emoji image.
URL: https://github.com/apache/incubator-airflow/pull/3918
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-3088
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This adds a 64px by 64px version of your logo, suitable for adding to slack
as a custom emoji.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This is a static PNG image and does not require tests.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
I did not document the inclusion of the image.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ship slack-compatible emoji in Airflow source
> ---------------------------------------------
>
> Key: AIRFLOW-3088
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3088
> Project: Apache Airflow
> Issue Type: Improvement
> Components: Documentation, ui
> Reporter: Seth Woodworth
> Priority: Trivial
>
> Airflow should ship a 64px by 64px png image suitable for inclusion into work
> chat systems as a custom emoji. Hipchat, Slack, & other services support
> custom emoji, and having a correctly formatted image at hand would let more
> people easily install custom emoji, and thereby increase Airflow's visibility.
> This will also be helpful for the slack operator/hook that can use an emoji
> as an icon.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
