[ 
https://issues.apache.org/jira/browse/AIRFLOW-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621800#comment-16621800
 ] 

Ash Berlin-Taylor commented on AIRFLOW-1595:
--------------------------------------------

(x-post from Githb) To resurrect an old PR: This PR might make sense, but as it 
is it would break any existing connections that are defined.

The issue is probably around how the connections are created. If for instance I 
create a connection like this `airflow connections -a --conn_id foo --conn_uri 
sqlite://path/to/file.sqlite` then I end up with `{"host": "path", "schema": 
"to/file.sqlite"}` so the fix wouldn't actually help for this case either.

The new options added recently (1.9.0, 1.10.0?) to be able to directly specify 
`--conn_host` probably make this PR as structured not needed, and a doc change 
in the SqliteHook all that is needed. (I'm not expecting you to do that, just 
commenting)

> SqliteHook is broken
> --------------------
>
>                 Key: AIRFLOW-1595
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1595
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.8.1
>            Reporter: Shintaro Murakami
>            Priority: Major
>
> SqliteHook is built using the host attribute of connection, but correctly we 
> should use the schema attribute. The path to the DB parsed from the URI is 
> set as schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to