Fokko commented on a change in pull request #3922: AIRFLOW-2952 Fix Kubernetes
CI
URL: https://github.com/apache/incubator-airflow/pull/3922#discussion_r219303693
##########
File path: tests/contrib/minikube/test_kubernetes_executor.py
##########
@@ -25,18 +26,25 @@
import re
try:
- check_call(["kubectl", "get", "pods"])
+ check_call(["/usr/local/bin/kubectl", "get", "pods"])
except Exception as e:
- raise unittest.SkipTest(
- "Kubernetes integration tests require a minikube cluster;"
- "Skipping tests {}".format(e)
- )
+ if os.environ.get('KUBERNETES_VERSION'):
+ raise e
+ else:
+ raise unittest.SkipTest(
+ "Kubernetes integration tests require a minikube cluster;"
+ "Skipping tests {}".format(e)
+ )
def get_minikube_host():
- host_ip = check_output(['minikube', 'ip'])
- if six.PY3:
- host_ip = host_ip.decode('UTF-8')
+ if os.environ['MINIKUBE_IP']:
Review comment:
Can we change this to:
```python
if "MINIKUBE_IP" in os.environ:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
