[
https://issues.apache.org/jira/browse/AIRFLOW-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632142#comment-16632142
]
ASF GitHub Bot commented on AIRFLOW-3124:
-----------------------------------------
feng-tao closed pull request #3958: [AIRFLOW-3124] Fix RBAC webserver debug mode
URL: https://github.com/apache/incubator-airflow/pull/3958
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/bin/cli.py b/airflow/bin/cli.py
index 1c5494ead1..09bd0c1806 100644
--- a/airflow/bin/cli.py
+++ b/airflow/bin/cli.py
@@ -870,8 +870,12 @@ def webserver(args):
print(
"Starting the web server on port {0} and host {1}.".format(
args.port, args.hostname))
- app = create_app_rbac(conf) if settings.RBAC else create_app(conf)
- app.run(debug=True, port=args.port, host=args.hostname,
+ if settings.RBAC:
+ app, _ = create_app_rbac(conf, testing=conf.get('core',
'unit_test_mode'))
+ else:
+ app = create_app(conf, testing=conf.get('core', 'unit_test_mode'))
+ app.run(debug=True, use_reloader=False if app.config['TESTING'] else
True,
+ port=args.port, host=args.hostname,
ssl_context=(ssl_cert, ssl_key) if ssl_cert and ssl_key else
None)
else:
os.environ['SKIP_DAGS_PARSING'] = 'True'
diff --git a/tests/cli/test_cli.py b/tests/cli/test_cli.py
index 93ec0576e6..aeafdd85fe 100644
--- a/tests/cli/test_cli.py
+++ b/tests/cli/test_cli.py
@@ -139,7 +139,21 @@ def test_ready_prefix_on_cmdline_dead_process(self):
self.assertEqual(get_num_ready_workers_running(self.gunicorn_master_proc), 0)
def test_cli_webserver_debug(self):
- p = psutil.Popen(["airflow", "webserver", "-d"])
+ env = os.environ.copy()
+ p = psutil.Popen(["airflow", "webserver", "-d"], env=env)
+ sleep(3) # wait for webserver to start
+ return_code = p.poll()
+ self.assertEqual(
+ None,
+ return_code,
+ "webserver terminated with return code {} in debug
mode".format(return_code))
+ p.terminate()
+ p.wait()
+
+ def test_cli_rbac_webserver_debug(self):
+ env = os.environ.copy()
+ env['AIRFLOW__WEBSERVER__RBAC'] = 'True'
+ p = psutil.Popen(["airflow", "webserver", "-d"], env=env)
sleep(3) # wait for webserver to start
return_code = p.poll()
self.assertEqual(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Broken webserver debug mode (RBAC)
> ----------------------------------
>
> Key: AIRFLOW-3124
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3124
> Project: Apache Airflow
> Issue Type: Bug
> Components: webapp, webserver
> Reporter: Aaron Kosel
> Assignee: Aaron Kosel
> Priority: Minor
>
> {code:java}
> Traceback (most recent call last):
> File "/usr/local/bin/airflow", line 7, in <module>
> exec(compile(f.read(), __file__, 'exec'))
> File "/airflow/airflow/bin/airflow", line 32, in <module>
> args.func(args)
> File "/airflow/airflow/utils/cli.py", line 74, in wrapper
> return f(*args, **kwargs)
> File "/airflow/airflow/bin/cli.py", line 875, in webserver
> app.run(debug=True, port=args.port, host=args.hostname,
> AttributeError: 'tuple' object has no attribute 'run'
> {code}
> Nearly the same issue as https://issues.apache.org/jira/browse/AIRFLOW-2204,
> but only affecting RBAC debug mode. The problem is that `create_app` returns
> a tuple, but the `cli` script expects to just receive the flask app back
> without the appbuilder.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
