itscaro edited a comment on issue #3981: [AIRFLOW-3133] Implement xcom_push 
flag for contrib's operators
URL: 
https://github.com/apache/incubator-airflow/pull/3981#issuecomment-425882500
 
 
   @ashb I will do the change for other operators in this PR. :)
   
   ---
   
   I updated other operators in a new commit.
   
   There is a special case with `GoogleCloudStorageToBigQueryOperator` which 
uses `max_id_key` as a flag for `xcom_push`, to harmonize argument between 
operators I added `do_xcom_push` as well and documented that `max_id_key` is 
used in combination with `do_xcom_push`
   
   Between `xcom_push` and `do_xcom_push`, should I rename to `xcom_push` for 
argument & `self.xcom_push_flag` for property as in base operators?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to