ashb commented on issue #3948: [AIRFLOW-3071] clear Val of Variable from the UI URL: https://github.com/apache/incubator-airflow/pull/3948#issuecomment-426220390 The code change looks sensible, but a couple of things: 1. We should add a test that covers this - probably in tests/www/test_views.py as a new test function in `TestVariableView` 2. Does this fix the form or is there a validation error saying value is required? 3. (Annoyingly, right now) there are two WWW versions that need updating. There is also www_rbac (which will become the only version, but for now please update both versions and both tests) Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
