[
https://issues.apache.org/jira/browse/AIRFLOW-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636379#comment-16636379
]
ASF GitHub Bot commented on AIRFLOW-2951:
-----------------------------------------
YingboWang opened a new pull request #3990: [AIRFLOW-2951] Update dag_run table
end_date when state change
URL: https://github.com/apache/incubator-airflow/pull/3990
The existing airflow only change dag_run table end_date value when
a user teminate a dag in web UI. The end_date will not be updated
if airflow detected a dag finished and updated its state.
This commit add end_date update in DagRun's set_state function to
make up tho problem mentioned above.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following
[Airflow-2951](https://issues.apache.org/jira/browse/AIRFLOW-2951) issues and
references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2951
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Same feature was merged in master before. This PR is to backport to
v1-10-test
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
tests/models.py:DagRunTest.test_dagrun_set_state_end_date
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
@ashb @KevinYang21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> dag_run end_date Null after a dag is finished
> ---------------------------------------------
>
> Key: AIRFLOW-2951
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2951
> Project: Apache Airflow
> Issue Type: Improvement
> Components: DagRun
> Reporter: Yingbo Wang
> Assignee: Yingbo Wang
> Priority: Major
> Fix For: 1.10.1
>
>
> dag_run table should have an end_date updated when a dag is finished.
> Currently only user activated dag termination request coming from UI may
> change the "end_date" in dag_run table. All scheduled dags that are
> automatically running by airflow will leave a NULL value after they fall into
> a "success" or "failed" state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
