[
https://issues.apache.org/jira/browse/AIRFLOW-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637063#comment-16637063
]
ASF GitHub Bot commented on AIRFLOW-3148:
-----------------------------------------
XD-DENG opened a new pull request #3995: [AIRFLOW-3148] Remove unnecessary arg
"parameters" in RedshiftToS3Transfer
URL: https://github.com/apache/incubator-airflow/pull/3995
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3148
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
"Parameters" are used to help render the SQL command. But in this operator,
only schema and table are needed. There is no SQL command to render.
By checking the code, we can also find argument "parameters" is never really
used.
(Fix a minor issue in the docstring as well)
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Argument "parameters" in RedshiftToS3Transfer is not necessary
> --------------------------------------------------------------
>
> Key: AIRFLOW-3148
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3148
> Project: Apache Airflow
> Issue Type: Improvement
> Components: operators
> Affects Versions: 1.10.0
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
>
> Argument "parameters" in RedshiftToS3Transfer is not necessary.
>
> Parameters are used to help render the SQL command. But in this operator,
> only schema and table are needed. There is no SQL command to render.
>
> Actually by checking the code, we can also realise argument "parameters" is
> never really used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
