[
https://issues.apache.org/jira/browse/AIRFLOW-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637594#comment-16637594
]
ASF GitHub Bot commented on AIRFLOW-3153:
-----------------------------------------
feng-tao opened a new pull request #3997: [AIRFLOW-3153] send dag last_run to
statsd
URL: https://github.com/apache/incubator-airflow/pull/3997
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3153
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Lyft has been running with this pr for over an year and numerous production
issues have been detected by the stats(e.g setting pageduty on the last run
time if it exceeds for certain threshold).
This PR adds statds logging for the DAG generation in Airflow, recording
the time spent processing each file; and
the last time it was processed (both as a unix timestamp and as an interval
in seconds).
```
Stats.gauge('last_runtime.example_bash_operator', 1.622376)
Stats.gauge('last_run.unixtime.example_bash_operator', 1512670855)
Stats.gauge('last_run.seconds_ago.example_bash_operator', 0.641343)
Stats.gauge('last_runtime.example_bash_operator', 1.629494)
Stats.gauge('last_run.unixtime.example_bash_operator', 1512670886)
Stats.gauge('last_run.seconds_ago.example_bash_operator', 0.526443)
```
Credit to original PR owner(@betodealmeida) at lyft
And fix some flake8 error
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Add stats, no need for test.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> send dag last_run to statsd
> ---------------------------
>
> Key: AIRFLOW-3153
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3153
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Tao Feng
> Assignee: Tao Feng
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
