[
https://issues.apache.org/jira/browse/AIRFLOW-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639123#comment-16639123
]
ASF GitHub Bot commented on AIRFLOW-3161:
-----------------------------------------
chang opened a new pull request #3999: []AIRFLOW-3161] Fix TaskInstance log
link in RBAC UI
URL: https://github.com/apache/incubator-airflow/pull/3999
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This change fixes the Log Url link in the new RBAC UI, which was linking to
DAG log list rather than task instance logs.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
`tests.models:TaskInstanceTest.test_log_url_rbac`
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Log Url link does not link to task instance logs in RBAC UI
> -----------------------------------------------------------
>
> Key: AIRFLOW-3161
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3161
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Eric Chang
> Assignee: Eric Chang
> Priority: Minor
> Attachments: image-2018-10-04-17-33-33-616.png,
> image-2018-10-04-17-34-12-135.png, image-2018-10-04-17-35-14-224.png
>
>
> In the new RBAC UI, the "Log Url" link (0) for Task instances don't link to
> the log for the task instances (1). Instead, they link to the DAG log list
> (2).
> (0)
> !image-2018-10-04-17-35-14-224.png|width=172,height=172!
> (1)
> !image-2018-10-04-17-34-12-135.png|width=660,height=376!
> (2)
> !image-2018-10-04-17-33-33-616.png|width=478,height=238!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
