[ 
https://issues.apache.org/jira/browse/AIRFLOW-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640959#comment-16640959
 ] 

ASF GitHub Bot commented on AIRFLOW-3168:
-----------------------------------------

dima-asana opened a new pull request #4014: [AIRFLOW-3168] add healthcheck for 
mysql setup in CI
URL: https://github.com/apache/incubator-airflow/pull/4014
 
 
   Make sure mysql is available before calling it in CI setup
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3168
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   Make sure mysql is available before calling it in CI setup
   
   ### Tests
   
   - [N/A] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Not user facing code.  Tested in local CI setup at e.g. 
https://travis-ci.com/dima-asana/incubator-airflow/jobs/150160744.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [N/A] In case of new functionality, my PR adds documentation that 
describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   (But no python diff so meaningless)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> mysql not always done set up in Travis by the time it's called
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-3168
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3168
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>            Reporter: Dima Kamalov
>            Assignee: Dima Kamalov
>            Priority: Minor
>
> seem to cause a build failure once every 5-10 tries, see e.g.  
> [https://travis-ci.org/apache/incubator-airflow/jobs/437669380]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to