kaxil closed pull request #4002: [AIRFLOW-3099] Complete list of optional
airflow.cfg sections
URL: https://github.com/apache/incubator-airflow/pull/4002
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/bin/cli.py b/airflow/bin/cli.py
index dbab8b38d8..14928bbd48 100644
--- a/airflow/bin/cli.py
+++ b/airflow/bin/cli.py
@@ -488,6 +488,24 @@ def _run(args, dag, ti):
@cli_utils.action_logging
def run(args, dag=None):
+ # Optional sections won't log an error if they're missing in airflow.cfg.
+ OPTIONAL_AIRFLOW_CFG_SECTIONS = [
+ 'atlas',
+ 'celery',
+ 'celery_broker_transport_options',
+ 'dask',
+ 'elasticsearch',
+ 'github_enterprise',
+ 'hive',
+ 'kerberos',
+ 'kubernetes',
+ 'kubernetes_node_selectors',
+ 'kubernetes_secrets',
+ 'ldap',
+ 'lineage',
+ 'mesos',
+ ]
+
if dag:
args.dag_id = dag.dag_id
@@ -510,18 +528,15 @@ def run(args, dag=None):
try:
conf.set(section, option, value)
except NoSectionError:
- optional_sections = [
- 'atlas', 'mesos', 'elasticsearch', 'kubernetes',
- 'lineage', 'hive'
- ]
- if section in optional_sections:
- log.debug('Section {section} Option {option} '
- 'does not exist in the
config!'.format(section=section,
-
option=option))
+ no_section_msg = (
+ 'Section {section} Option {option} '
+ 'does not exist in the config!'
+ ).format(section=section, option=option)
+
+ if section in OPTIONAL_AIRFLOW_CFG_SECTIONS:
+ log.debug(no_section_msg)
else:
- log.error('Section {section} Option {option} '
- 'does not exist in the
config!'.format(section=section,
-
option=option))
+ log.error(no_section_msg)
settings.configure_vars()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
