ashb commented on a change in pull request #3992: [AIRFLOW-620] Feature to tail
custom number of logs instead of rendering whole log
URL: https://github.com/apache/incubator-airflow/pull/3992#discussion_r223701009
##########
File path: airflow/www/templates/airflow/ti_log.html
##########
@@ -29,6 +29,28 @@ <h4>{{ title }}</h4>
</a>
</li>
{% endfor %}
+ {% if tailing_required %}
+ <ul class="nav nav-pills pull-right">
+ <li>
+ <div class="dropdown">
+ <button class="btn btn-primary dropdown-toggle" type="button"
data-toggle="dropdown" id="tailLinesList">
+ <span id="selected">Tail Logs</span><span class="caret"></span>
+ </button>
+ <ul class="dropdown-menu" aria-labelledby="tailLinesList"
id="linesList">
+ {% for tail_line in tail_lines_list %}
Review comment:
I'm not a fan of this being shown for log storage methods (such as S3/GCP)
that don't support this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
