[
https://issues.apache.org/jira/browse/AIRFLOW-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644148#comment-16644148
]
ASF GitHub Bot commented on AIRFLOW-3178:
-----------------------------------------
ashb opened a new pull request #4029: [AIRFLOW-3178] Handle percents signs in
configs for airflow run
URL: https://github.com/apache/incubator-airflow/pull/4029
Make sure you have checked _all_ steps below.
### Jira
- [x] https://issues.apache.org/jira/browse/AIRFLOW-3178
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
To have a `%` appear in the config file, it needs to appear as `%%`. However
the way we were generating the temporary config for `airflow run` it would
loose that escaping and cause a config error.
This fixes the way we generate that temp config by using methods built-in to
ConfigParser to get the raw values (rather than grubbing around with
`deepcopy()`). I have left this PR as three individual commits as I think it
will be easier to review in it's current form.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> `airflow run` config doens't cope with % in config values.
> ----------------------------------------------------------
>
> Key: AIRFLOW-3178
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3178
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Ash Berlin-Taylor
> Priority: Major
> Fix For: 1.10.1
>
>
> ConfigParser uses %-signs for interpolation, so if you need a literal % in
> airflow.cfg it needs to be escaped in by specifying them as {{%%}}), but by
> the time they are written out to the temporary config that is passed to
> `airflow run` they escaping is lost.
> This is also true for configuration via environment variables, where {{%}}
> doesn't need to be escaped at all, but is included (sometimes needlessly) in
> the config un-escaped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
