dima-asana commented on a change in pull request #4014: [AIRFLOW-3168] add
healthcheck for mysql setup in CI
URL: https://github.com/apache/incubator-airflow/pull/4014#discussion_r223952832
##########
File path: scripts/ci/3-setup-databases.sh
##########
@@ -20,4 +20,9 @@ set -exuo pipefail
MYSQL_HOST=mysql
+# make sure mysql is done setting up
+while ! mysqladmin ping -h ${MYSQL_HOST} -u root --silent; do
+ sleep 1
+done
Review comment:
> shouldn't the while loop need to exist after some time instead of looping
forever?
done
> Though also: why do we set up mysql when we are running against sqlite or
postgres?
done [edit: actually in progress, a bit more dependencies than i anticipated]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
