[
https://issues.apache.org/jira/browse/AIRFLOW-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646558#comment-16646558
]
ASF GitHub Bot commented on AIRFLOW-2744:
-----------------------------------------
oliviersm199 opened a new pull request #4036: [AIRFLOW-2744] Allow RBAC to
accept plugins for views and links.
URL: https://github.com/apache/incubator-airflow/pull/4036
### Description
Airflow Users that wish to create plugins for the new www_rbac UI can not
add plugin views or links. This PR fixes that by letting a user specify their
plugins for www_rbac and maintains backwards compatibility with the existing
plugins system.
Adds two additional members of an AirflowPlugin class to cover role based
views and role based menu items. Specifies that the user can create a
dictionary which has the metadata necessary to create a FlaskAppBuilder
BaseView or MenuItem. This lets the plugins manager extend to the new www_rbac
GUI.
### Tests
Adds unit tests under the plugins manager to test that the www_rbac views
and menu links get added successfully.
### Documentation
Demonstrates in the plugins page how a user would create plugins for the new
UI with an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> RBAC app doesn't integrate plugins (blueprints etc)
> ---------------------------------------------------
>
> Key: AIRFLOW-2744
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2744
> Project: Apache Airflow
> Issue Type: Bug
> Components: webapp, webserver
> Affects Versions: 2.0.0
> Reporter: David Dossett
> Priority: Major
>
> In the current 1.10.0rc tag, the new RBAC app doesn't integrate any plugins
> created by a user extending Airflow. In the old www/app.py you had the
> [integrate_plugins|https://github.com/apache/incubator-airflow/blob/f1083cbada337731ed0b7e27b09eee7a26c8189a/airflow/www/app.py#L126]
> function. But currently the
> [www_rbac/app.py|https://github.com/apache/incubator-airflow/blob/f1083cbada337731ed0b7e27b09eee7a26c8189a/airflow/www_rbac/app.py]
> doesn't pull in any plugins from the plugin_manager. So nothing you do to
> extend Airflow's webapp will work.
> I think adding the code for registering the blueprints and menu links is a
> pretty simple fix. I'm not sure how the FAB system is handling the same
> functionality as Flask-Admin views though.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
