Fokko commented on a change in pull request #4039: [AIRFLOW-3046] Fix ECS
Operator mistakenly reports success
URL: https://github.com/apache/incubator-airflow/pull/4039#discussion_r224663367
##########
File path: airflow/contrib/operators/ecs_operator.py
##########
@@ -139,6 +140,10 @@ def _check_success_task(self):
raise AirflowException(response)
for task in response['tasks']:
+ if re.match(r'Host .+?\(.+?\) terminated\.',
task.get('stoppedReason', '')):
Review comment:
Maybe add a comment here to elaborate where this regex matches on. Do you
know what other `stoppedReasons` might be? Just to be sure that it doesn't
conflict with other reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
