danmactough commented on a change in pull request #4039: [AIRFLOW-3046] Fix ECS
Operator mistakenly reports success
URL: https://github.com/apache/incubator-airflow/pull/4039#discussion_r224664053
##########
File path: airflow/contrib/operators/ecs_operator.py
##########
@@ -139,6 +140,10 @@ def _check_success_task(self):
raise AirflowException(response)
for task in response['tasks']:
+ if re.match(r'Host .+?\(.+?\) terminated\.',
task.get('stoppedReason', '')):
Review comment:
> Do you know what other `stoppedReasons` might be?
That's a great question. The [only documentation I can
find](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/stopped-task-errors.html)
identifies "**_some_** possible reasons and their explanations," which doesn't
give a lot of confidence that the list is complete.
I would like to edit that check to match "terminated" or "stopped" though,
having seen that documentation, now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
