Fokko commented on a change in pull request #4015: [AIRFLOW-2789] Create single
node DataProc cluster
URL: https://github.com/apache/incubator-airflow/pull/4015#discussion_r224668410
##########
File path: airflow/contrib/operators/dataproc_operator.py
##########
@@ -170,6 +172,7 @@ def __init__(self,
idle_delete_ttl=None,
auto_delete_time=None,
auto_delete_ttl=None,
+ single_node=False,
Review comment:
Right now if feels a bit redundant te me. In this case you would need to set
both the number of workers, and the `single_node` to True. Since the number of
workers is a required argument, I'd say that setting `num_workers` would
already suggest that you want a single node cluster. I'd set the `single_node =
num_workers == 0` to still be explicit in the code, but having a less redundant
interface to the developer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
