Fokko commented on a change in pull request #3873: [Airflow-2760] Decouple DAG
parsing loop from scheduler loop
URL: https://github.com/apache/incubator-airflow/pull/3873#discussion_r224670598
##########
File path: tests/jobs.py
##########
@@ -1264,6 +1262,7 @@ def setUp(self):
session.query(models.DagRun).delete()
session.query(models.ImportError).delete()
session.commit()
+ session.close()
Review comment:
Same as above. Can we do this with a with settings.Session() as session:
statement, that will make it much cleaner and less error prone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
