[
https://issues.apache.org/jira/browse/AIRFLOW-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated AIRFLOW-3183:
--------------------------------------
Affects Version/s: 1.10.0
> Potential Bug in
> utils/dag_processing/DagFileProcessorManager.max_runs_reached()
> --------------------------------------------------------------------------------
>
> Key: AIRFLOW-3183
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3183
> Project: Apache Airflow
> Issue Type: Bug
> Affects Versions: 1.10.0
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
> Fix For: 2.0.0
>
>
> In
> [https://github.com/apache/incubator-airflow/blob/df7c16a3ce01625277dd2e5c4ce4ed096dcfbb40/airflow/utils/dag_processing.py#L581,]
> the condition is to ensure the function will return False if any file's
> run_count is smaller than max_run.
> But the operator used here is "!=". Instead, it should be "<".
> This is because in *DagFileProcessorManager*, there is no statement helping
> limit the upper limit of run_count. It's possible that files' run_count will
> be bigger than max_run. In such case, max_runs_reached() method may fail its
> purpose.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
