Fokko commented on a change in pull request #4023: [AIRFLOW-3174] Refine
Docstring for SQL Operators
URL: https://github.com/apache/incubator-airflow/pull/4023#discussion_r224700379
##########
File path: airflow/operators/mssql_operator.py
##########
@@ -31,6 +31,8 @@ class MsSqlOperator(BaseOperator):
:param sql: the sql code to be executed
:type sql: str or string pointing to a template file with .sql
extension. (templated)
+ :param parameters: (optional) the parameters to render the SQL query with.
+ :type parameters: mapping or iterable
Review comment:
Could you fix the order? :) The `sql` one comes before `mssql_conn_id`, but
in the docstring it is the other way around. Also `autocommit is missing here`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
