ashb commented on a change in pull request #4039: [AIRFLOW-3046] Fix ECS
Operator mistakenly reports success
URL: https://github.com/apache/incubator-airflow/pull/4039#discussion_r224703994
##########
File path: airflow/contrib/operators/ecs_operator.py
##########
@@ -139,6 +140,15 @@ def _check_success_task(self):
raise AirflowException(response)
for task in response['tasks']:
+ # This is a `stoppedReason` that indicates a task has not
+ # successfully finished, but there is no other indication of
failure
+ # in the response.
+ # See,
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/stopped-task-errors.html
# noqa E501
+ if re.match(r'Host EC2 \(instance .+?\) (stopped|terminated)\.',
Review comment:
Do we need this check? A look at the doc you linked to and it sounds like
any of these other stoppedReasons would also be "we had to kill your task" type
things and should be an error to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
