Fokko commented on a change in pull request #3893: [AIRFLOW-2932] 
GoogleCloudStorageHook - allow compression of file
URL: https://github.com/apache/incubator-airflow/pull/3893#discussion_r224715870
 
 

 ##########
 File path: airflow/contrib/operators/file_to_gcs.py
 ##########
 @@ -49,6 +52,7 @@ def __init__(self,
                  bucket,
                  google_cloud_storage_conn_id='google_cloud_default',
                  mime_type='application/octet-stream',
+                 gzip=False,
 
 Review comment:
   One last comment, can you move the `gzip` argument to the very end? 
Otherwise backward compatibility will be broken.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to