[
https://issues.apache.org/jira/browse/AIRFLOW-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648991#comment-16648991
]
ASF GitHub Bot commented on AIRFLOW-3203:
-----------------------------------------
XD-DENG opened a new pull request #4049: [AIRFLOW-3203] Fix DockerOperator &
its test
URL: https://github.com/apache/incubator-airflow/pull/4049
### Jira
- https://issues.apache.org/jira/browse/AIRFLOW-3203
### Description
- For argument `image`, no need to explicitly add "latest" if tag is omitted.
"latest" will be used by default if no tag provided. This is handled by
`docker` package itself.
- Intermediate variable `cpu_shares` is not needed.
- Fix wrong usage of `cpu_shares` and `cpu_shares`.
Based on
https://docker-py.readthedocs.io/en/stable/api.html#docker.api.container.ContainerApiMixin.create_host_config,
They should be an arguments of self.cli.create_host_config() rather than
APIClient.create_container().
- Change name of the corresponding test script, to ensure it can be
discovered.
- Fix the test itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Bugs in DockerOperator & its test
> ---------------------------------
>
> Key: AIRFLOW-3203
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3203
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators, tests
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Critical
>
> Usage of `cpu_shares` and `cpu_shares` is incorrect in DockerOperator, based
> on documentation of Python package "docker".
> In addition, its test is not really working due to incorrect file name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
