[
https://issues.apache.org/jira/browse/AIRFLOW-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652906#comment-16652906
]
ASF GitHub Bot commented on AIRFLOW-1508:
-----------------------------------------
jmcarp opened a new pull request #4059: [AIRFLOW-1508] Add SKIPPED to task
states.
URL: https://github.com/apache/incubator-airflow/pull/4059
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Add SKIPPED to task states. Discussed in #2519; cc @ashb.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Skipped state not part of State.task_states
> -------------------------------------------
>
> Key: AIRFLOW-1508
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1508
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Ace Haidrey
> Assignee: Ace Haidrey
> Priority: Major
>
> In the airflow.state module,
> [State.task_state|https://github.com/apache/incubator-airflow/blob/master/airflow/utils/state.py#L44]
> doesn't include the {{SKIPPED}} state even though the {{TaskInstance}}
> object has it. I was wondering if this was on purpose or a bug. I would think
> it should be part of the task_state object since that makes sense and will
> help some of my workflows to not have to add this in manually.
> I'm not sure who the appropriate person to ask is so thinking I'll tag some
> people and get some feedback (hopefully that's okay)..
> CC [~criccomini] [~bolke] [~allisonwang]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
