Eronarn commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism URL: https://github.com/apache/incubator-airflow/pull/3584#issuecomment-430792452 Need to head out but I just pushed a bunch of new commits, including a lot of test code. The only major untested code is `DAG.send_sla_notifications` which should be a relatively easy addition next time I get an hour to work on this. I have been testing in a local Docker container with these commands to run the new tests: ``` nosetests -v tests/utils/test_sla.py nosetests -v tests/core.py:CoreTest.test_sla_deprecated_arg_warning nosetests -v tests/core.py:CoreTest.test_sla_redundant_arg_warning airflow resetdb -y && nosetests -v tests/models.py:DagTest ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
