[
https://issues.apache.org/jira/browse/AIRFLOW-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657329#comment-16657329
]
ASF GitHub Bot commented on AIRFLOW-3233:
-----------------------------------------
aoen opened a new pull request #4069: [AIRFLOW-3233] Fix deletion of DAGs in
the UI
URL: https://github.com/apache/incubator-airflow/pull/4069
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3233) issues and references
them in the PR title.
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Currently deleting DAGs that exist on the scheduler but not the webserver is
not possible because the DAG id in the deletion URL comes from the webserver
DAG object.
e.g. http://localhost:8080/delete?dag_id= instead of
http://localhost:8080/delete?dag_id=example_kubernetes_executor
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
UI Fix, tested both RBAC and regular.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [X] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Dag deletion in the UI doesn't work
> -----------------------------------
>
> Key: AIRFLOW-3233
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3233
> Project: Apache Airflow
> Issue Type: Bug
> Components: webserver
> Reporter: Dan Davydov
> Assignee: Dan Davydov
> Priority: Major
>
> Dag deletion in the UI doesn't work, DAGs can only be deleted if the DAG
> doesn't exist in the DAGBag, but if the DAG doesn't exist in the DAGBag the
> deletion URL gets passed an empty DAG id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
