jj-ian commented on a change in pull request #4083: [AIRFLOW-3211] Reattach to
GCP Dataproc jobs upon Airflow restart
URL: https://github.com/apache/incubator-airflow/pull/4083#discussion_r227418264
##########
File path: airflow/contrib/hooks/gcp_dataproc_hook.py
##########
@@ -33,12 +33,82 @@ def __init__(self, dataproc_api, project_id, job,
region='global',
self.dataproc_api = dataproc_api
self.project_id = project_id
self.region = region
+
+ # Check if the job to submit is already running on the cluster.
+ # If so, don't resubmit the job.
+ try:
+ cluster_name = job['job']['placement']['clusterName']
+ except KeyError:
+ self.log.error('Job to submit is incorrectly configured.')
+ raise
+
+ jobs_on_cluster_response =
dataproc_api.projects().regions().jobs().list(
+ projectId=self.project_id,
+ region=self.region,
+ clusterName=cluster_name).execute()
+
+ UUID_LENGTH = 9
Review comment:
The Airflow Dataproc job builder truncates the UUID to 8 characters
[here](https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/gcp_dataproc_hook.py#L94),
so the task name submitted to Airflow consists of the task ID + underscore +
an 8 digit ID. The 9 characters in my PR represents the 8 UUID characters plus
the underscore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
