XD-DENG commented on a change in pull request #4084: [AIRFLOW-3205] Support
multipart uploads to GCS
URL: https://github.com/apache/incubator-airflow/pull/4084#discussion_r227433513
##########
File path: airflow/contrib/hooks/gcs_hook.py
##########
@@ -191,6 +193,15 @@ def upload(self, bucket, object, filename,
:type mime_type: str
:param gzip: Option to compress file for upload
:type gzip: bool
+ :param multipart: If true, split the upload into multiple HTTP requests
+ :type multipart: bool
+ :param chunksize: Size in bytes of each upload chunk when performing a
+ multipart upload; must be a multiple of 256KiB
(262144 bytes)
Review comment:
May be good to mention your default value (256Mb) here in the docstring?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
