[
https://issues.apache.org/jira/browse/AIRFLOW-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662319#comment-16662319
]
ASF GitHub Bot commented on AIRFLOW-3250:
-----------------------------------------
smentek opened a new pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for
not authorised connection calls
URL: https://github.com/apache/incubator-airflow/pull/4090
Password stay None value and not None (str) in case there is no password set
through webadmin interfaces.
This is fix for connections for Redis that not expect autorisation from
clients.
Fixes originally implemented:
https://issues.apache.org/jira/browse/AIRFLOW-999
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/AIRFLOW-3250) issues and
references them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-3250
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
his functionality is trivial further description is NOT needed.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
/tests/contrib/hooks/test_redis_hook.py
/tests/contrib/sensors/test_redis_sensor.py
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
This functionality is trivial and documentation is NOT needed.
### Code Quality
- [X] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix for Redis Hook for not authorised connection calls.
> -------------------------------------------------------
>
> Key: AIRFLOW-3250
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3250
> Project: Apache Airflow
> Issue Type: Bug
> Components: db
> Affects Versions: 1.9.0, 1.10.0, 2.0.0
> Reporter: Pawel Graczyk
> Assignee: Pawel Graczyk
> Priority: Minor
> Fix For: 1.9.0, 1.10.0
>
>
> Current implementation of AIRFLOW-999 needs fixes.
> 1. Password stays None and not 'None' (str) in case there is no password set,
> otherwise AUTH call will be send and that produces errors on connection to
> Redis that does not expect authorisation calls.
> 2. Reference to connection is set on get_conn hook object method rather than
> on __init__
> 3. Trivial method key_exists of hook object removed
> 4. Fixes for unit tests so it deal with hook code and not related
> dependencies such as Redis and DB connections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
